Officer records assessment decision #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickjfl
force-pushed
the
50-officer-records-assessment-decision
branch
2 times, most recently
from
dec948e to
27b4f7e
Compare
edavey
approved these changes
Dec 10, 2024
db/migrate/20240913140449_add_decision_enum_to_landing_application.rb
Outdated
Show resolved
Hide resolved
| @@ -26,7 +26,7 @@ | |||
| row.with_cell(text: application.landing_date) | |||
| row.with_cell(text: application.departure_date) | |||
| row.with_cell(text: application.application_submitted_at.to_date, html_attributes: { id: "submission-date" }) | |||
| row.with_cell(text: '') | |||
| application.application_decision ? row.with_cell(text: application.application_decision.capitalize, html_attributes: { id: "application-#{application.id}" }) : row.with_cell {govuk_button_link_to 'Make a decision', new_officer_landing_application_decision_path(landing_application_id: application.id), class: "govuk-!-margin-bottom-0", html_attributes: { id: "application-#{application.id}" }} | |||
There was a problem hiding this comment.
this looks like a good candidate for a view component maybe? (Hurting my eyes to try to parse this long expression!)
| end | ||
|
|
||
| def and_i_should_see_my_decision | ||
| page.find_by_id("application-#{@first_application_id}", text: "Approved") |
There was a problem hiding this comment.
do you think we ought to have a "flash message" of the "success" variety to reassure the assessor that the decision has been recorded?
I also find it doubly reassuring in situations where I'm redirected to an index page to have a confirmation of which item it is I've just operated on, e.g.
Application ID ABC123 has been rejected/accepted
| application_decision = [:approved, :denied, nil].sample | ||
| s.application_decision = application_decision | ||
| if [:approved, :denied].include?(application_decision) | ||
| s.application_decision_made_at = between_submission_and_landing_dates(landing_date, application_submitted_at) |
There was a problem hiding this comment.
thanks for making this seeding realistic
|
also: I think our calls-to-action for the assessor ought to be a little less shouty, perhaps?
|
patrickjfl
force-pushed
the
50-officer-records-assessment-decision
branch
from
27b4f7e to
9e4fb86
Compare
patrickjfl
force-pushed
the
50-officer-records-assessment-decision
branch
from
9e4fb86 to
4f8873d
Compare
…User model We must specify `optional: true` because our landing applications will only have an assessor association once they have been assessed.
This will allow us to use the method in different test files.
This gives us additional query methods on the model: https://apidock.com/rails/ActiveRecord/Enum
This form object will allow us to validate the presence and value of an application decision in our controller method at the point that we want to update the model with the decision.
patrickjfl
force-pushed
the
50-officer-records-assessment-decision
branch
from
4f8873d to
acabfb5
Compare
This will allow us to user `assert_template` in our test files, which was deprecated in Rails 5.0. It is nonetheless useful for us in allowing us to test conditional paths in our controller methods.
patrickjfl
force-pushed
the
50-officer-records-assessment-decision
branch
from
acabfb5 to
2e1633d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete new journey for our officer user, allowing them to approve or deny an application for landing. This involves changes at the data layer (associating our LandingApplication and User models), as well as an update to our application seeding to ensure applications have a decision (or no decision) assigned to them at random.
For now we don't have readable application IDs, so we are lacking a clear visual indication of the application being assessed. This will have to come in a future iteration.